feat: Arc instead of Box<dyn EngineData> for add_files API #1354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachschuermann
changed the title
|
discussed some with @nicklan offline. figured I'd go ahead and open this to get some discussion but not sure if we actually want to pursue this |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1354 +/- ##
=======================================
Coverage 84.76% 84.76%
=======================================
Files 113 113
Lines 28421 28425 +4
Branches 28421 28425 +4
=======================================
+ Hits 24091 24095 +4
Misses 3194 3194
Partials 1136 1136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Opening for some discussion: do we want to take a Box or an Arc for
transaction.add_files?Currently we take a
Box<dyn EngineData>- this means engine can't use it again after handing to our transaction. I'm raising this to consider Arc since none of our APIs actually require ownership - we can just take a shared Arc and everything basically "just works".Though this brings up whether or not we want to allow this flexibility, as the add_files_metadata is not very useful outside of a transaction and in the future a
Transactionshould be able to just rebase itself?This PR affects the following public APIs
transaction.add_filestakes anArc<dyn EngineData>instead ofBox<dyn EngineData>How was this change tested?
existing